[jacorb-bugs] [Bug 978] New: Request for non_existent() call on a dead object to not generate an error level log message
bugzilla-daemon at jacorb.org
bugzilla-daemon at jacorb.org
Wed Feb 26 23:38:24 CET 2014
http://www.jacorb.org/bugzilla/show_bug.cgi?id=978
Bug ID: 978
Summary: Request for non_existent() call on a dead object to
not generate an error level log message
Product: JacORB
Version: 3.4
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5
Component: ORB
Assignee: jacorb-bugs at lists.spline.inf.fu-berlin.de
Reporter: rhash at tibco.com
Note: entering this to capture email discussion with Nick.
Currently in 3.4 calling non_existent() on a dead object generates an error
level log message with a stack trace. Very old versions of JacORB (e.g. 2.3.1)
just silently threw the exception and let the caller deal with it).
This is happening in the orb.Delegate, servant_preinvoke(), which throws a
OBJECT_NOT_EXIST, but the outer catch{} block is calling
logger.error("unexpected exception during servant_preinvoke", e);
before it re-throws the exception.
Basically we think that a OBJ_NOT_EXISTS on a non_existent should just silently
return 'false' (without error level logging).
Suggestion from Nick:
########################
So we would have
public ServantObject servant_preinvoke( org.omg.CORBA.Object self,
String operation,
@SuppressWarnings("rawtypes") Class expectedType ) and
/**
* Only called by servant_preinvoke. Special case method used by non_existent
to disable logging for object not exist
*/
private ServantObject servant_preinvoke( org.omg.CORBA.Object self,
String operation,
@SuppressWarnings("rawtypes") Class expectedType,
boolean logObjectNotExist )
The test case could do something similar to org.jacorb.test.util.JDKLoggerTest
where it checks the file contents for the log file. And the actual test could
reuse orb.NonExistentLocalTest.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spline.inf.fu-berlin.de/pipermail/jacorb-bugs/attachments/20140226/cb42bd92/attachment.html>
More information about the jacorb-bugs
mailing list