[jacorb-bugs] [Bug 947] New: Invalid disconnect logic on bad connection

[bugzilla-daemon at jacorb.org]

http://www.jacorb.org/cgi-bin/bugzilla/show_bug.cgi?id=947

           Summary: Invalid disconnect logic on bad connection
           Product: JacORB
           Version: 3.1
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P2
         Component: ORB
        AssignedTo: jacorb-bugs at lists.spline.inf.fu-berlin.de
        ReportedBy: englundGiant at gmail.com


If I have a connection attempting to be made to a bad object the client
connection will remain in the waitforconnect state forever.  If I turn on the
following properties:
jacorb.connection.server.timeout=5000 
jacorb.client.pending_reply_timeout=5000
jacorb.connection.client.idle.timeout=5000 

it catches the bad connection however, the logic in the disconnect call seems
flawed.  

Line 1460:
if (disconnectAfterNonRecoverableSystemException) {
            return;
}

Since the default value is 'true', this will abort the disconnect of a bad
connection.  This leaves the thread in the waitforconnect state forever, even
though I set a timeout.

Shouldn't the logic be:
if (!disconnectAfterNonRecoverableSystemException) {
            return;
}


With this change and the above properties the Client connections are
successfully closed and the thread pool no longer continues to grow.


-- 
Configure bugmail: http://www.jacorb.org/cgi-bin/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.